ietm64/LoreMind
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Changement sur le Readme

Browse Source 
Ajout d'une partie spécifique pour des PNJ dans la partie campagne
This commit is contained in:
IETM_FIXE\ietm6
2026-04-27 15:48:04 +02:00
parent a92e31b187
commit d2cf9f8c5c
80 changed files with 1771 additions and 719 deletions
Download Patch File Download Diff File Expand all files Collapse all files

159
core/src/test/java/com/loremind/application/campaigncontext/NpcServiceTest.java Normal file
View File

@@ -0,0 +1,159 @@
package com.loremind.application.campaigncontext;
import com.loremind.domain.campaigncontext.Npc;
import com.loremind.domain.campaigncontext.ports.NpcRepository;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.ArgumentCaptor;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;
import java.util.List;
import java.util.Optional;
import static org.junit.jupiter.api.Assertions.*;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.*;
/**
* Test unitaire pour NpcService.
* Couvre la création (avec auto-calcul de l'order), la lecture, la mise à jour
* (incl. cas non trouvé), la suppression, et le calcul d'order.
*/
@ExtendWith(MockitoExtension.class)
public class NpcServiceTest {
@Mock
private NpcRepository npcRepository;
@InjectMocks
private NpcService npcService;
private Npc testNpc;
@BeforeEach
void setUp() {
testNpc = Npc.builder()
.id("npc-1")
.name("Borin le forgeron")
.markdownContent("# Borin\nForgeron nain")
.campaignId("camp-1")
.order(1)
.build();
}
@Test
void testCreateNpc_WithExplicitOrder() {
when(npcRepository.save(any(Npc.class))).thenReturn(testNpc);
Npc result = npcService.createNpc(
new NpcService.NpcData("Borin le forgeron", "# Borin", "camp-1", 5));
assertNotNull(result);
ArgumentCaptor<Npc> captor = ArgumentCaptor.forClass(Npc.class);
verify(npcRepository).save(captor.capture());
assertEquals(5, captor.getValue().getOrder());
}
@Test
void testCreateNpc_AutoComputesNextOrder_WhenNullProvided() {
// Existant : 2 PNJ avec orders 0 et 3 → next = 4
Npc a = Npc.builder().id("a").campaignId("camp-1").order(0).build();
Npc b = Npc.builder().id("b").campaignId("camp-1").order(3).build();
when(npcRepository.findByCampaignId("camp-1")).thenReturn(List.of(a, b));
when(npcRepository.save(any(Npc.class))).thenReturn(testNpc);
npcService.createNpc(new NpcService.NpcData("Nouveau", null, "camp-1", null));
ArgumentCaptor<Npc> captor = ArgumentCaptor.forClass(Npc.class);
verify(npcRepository).save(captor.capture());
assertEquals(4, captor.getValue().getOrder());
}
@Test
void testCreateNpc_FirstNpcGetsOrderZero() {
when(npcRepository.findByCampaignId("camp-1")).thenReturn(List.of());
when(npcRepository.save(any(Npc.class))).thenReturn(testNpc);
npcService.createNpc(new NpcService.NpcData("Premier", null, "camp-1", null));
ArgumentCaptor<Npc> captor = ArgumentCaptor.forClass(Npc.class);
verify(npcRepository).save(captor.capture());
assertEquals(0, captor.getValue().getOrder());
}
@Test
void testGetNpcById_Found() {
when(npcRepository.findById("npc-1")).thenReturn(Optional.of(testNpc));
Optional<Npc> result = npcService.getNpcById("npc-1");
assertTrue(result.isPresent());
assertEquals("Borin le forgeron", result.get().getName());
}
@Test
void testGetNpcById_NotFound() {
when(npcRepository.findById("missing")).thenReturn(Optional.empty());
Optional<Npc> result = npcService.getNpcById("missing");
assertFalse(result.isPresent());
}
@Test
void testGetNpcsByCampaignId_DelegatesToRepository() {
Npc a = Npc.builder().id("a").campaignId("camp-1").order(1).build();
Npc b = Npc.builder().id("b").campaignId("camp-1").order(2).build();
when(npcRepository.findByCampaignId("camp-1")).thenReturn(List.of(a, b));
List<Npc> result = npcService.getNpcsByCampaignId("camp-1");
assertEquals(2, result.size());
verify(npcRepository).findByCampaignId("camp-1");
}
@Test
void testUpdateNpc_Success() {
when(npcRepository.findById("npc-1")).thenReturn(Optional.of(testNpc));
when(npcRepository.save(any(Npc.class))).thenAnswer(inv -> inv.getArgument(0));
Npc result = npcService.updateNpc("npc-1",
new NpcService.NpcData("Borin renommé", "# v2", "camp-1", 7));
assertEquals("Borin renommé", result.getName());
assertEquals("# v2", result.getMarkdownContent());
assertEquals(7, result.getOrder());
}
@Test
void testUpdateNpc_OrderNullPreservesExistingOrder() {
when(npcRepository.findById("npc-1")).thenReturn(Optional.of(testNpc));
when(npcRepository.save(any(Npc.class))).thenAnswer(inv -> inv.getArgument(0));
Npc result = npcService.updateNpc("npc-1",
new NpcService.NpcData("Borin", "# txt", "camp-1", null));
// testNpc avait order=1 → préservé
assertEquals(1, result.getOrder());
}
@Test
void testUpdateNpc_NotFoundThrows() {
when(npcRepository.findById("missing")).thenReturn(Optional.empty());
IllegalArgumentException ex = assertThrows(IllegalArgumentException.class,
() -> npcService.updateNpc("missing",
new NpcService.NpcData("x", null, "camp-1", null)));
assertTrue(ex.getMessage().contains("missing"));
verify(npcRepository, never()).save(any());
}
@Test
void testDeleteNpc_DelegatesToRepository() {
npcService.deleteNpc("npc-1");
verify(npcRepository).deleteById("npc-1");
}
}

65
core/src/test/java/com/loremind/application/generationcontext/CampaignStructuralContextBuilderTest.java
View File

@@ -3,12 +3,15 @@ package com.loremind.application.generationcontext;
import com.loremind.domain.campaigncontext.Arc;
import com.loremind.domain.campaigncontext.Campaign;
import com.loremind.domain.campaigncontext.Chapter;
import com.loremind.domain.campaigncontext.Character;
import com.loremind.domain.campaigncontext.Npc;
import com.loremind.domain.campaigncontext.Scene;
import com.loremind.domain.campaigncontext.SceneBranch;
import com.loremind.domain.campaigncontext.ports.ArcRepository;
import com.loremind.domain.campaigncontext.ports.CampaignRepository;
import com.loremind.domain.campaigncontext.ports.ChapterRepository;
import com.loremind.domain.campaigncontext.ports.CharacterRepository;
import com.loremind.domain.campaigncontext.ports.NpcRepository;
import com.loremind.domain.campaigncontext.ports.SceneRepository;
import com.loremind.domain.generationcontext.CampaignStructuralContext;
import org.junit.jupiter.api.BeforeEach;
@@ -43,6 +46,8 @@ public class CampaignStructuralContextBuilderTest {
private SceneRepository sceneRepository;
@Mock
private CharacterRepository characterRepository;
@Mock
private NpcRepository npcRepository;
@InjectMocks
private CampaignStructuralContextBuilder builder;
@@ -144,6 +149,66 @@ public class CampaignStructuralContextBuilderTest {
assertEquals("(scène inconnue)", scene1Summary.branches().get(1).targetSceneName());
}
@Test
void testBuild_ProjectsCharactersAndNpcsWithSnippets() {
Character pj1 = Character.builder().id("c-1").campaignId("camp-1").order(1)
.name("Aragorn")
.markdownContent("# Aragorn\n\nRôdeur du Nord, héritier d'Isildur.")
.build();
Character pj2 = Character.builder().id("c-2").campaignId("camp-1").order(2)
.name("Legolas")
.markdownContent(null) // pas de snippet → string vide
.build();
Npc npc1 = Npc.builder().id("n-1").campaignId("camp-1").order(2)
.name("Borin le forgeron")
.markdownContent("# Borin\n\nNain barbu au regard perçant, ancien clan Feuillefer.")
.build();
Npc npc2 = Npc.builder().id("n-2").campaignId("camp-1").order(1)
.name("Dame Elara")
.markdownContent("")
.build();
when(campaignRepository.findById("camp-1")).thenReturn(Optional.of(campaign));
when(arcRepository.findByCampaignId("camp-1")).thenReturn(List.of());
when(characterRepository.findByCampaignId("camp-1")).thenReturn(List.of(pj2, pj1));
when(npcRepository.findByCampaignId("camp-1")).thenReturn(List.of(npc1, npc2));
CampaignStructuralContext ctx = builder.build("camp-1");
// PJ triés par order croissant
assertEquals(2, ctx.characters().size());
assertEquals("Aragorn", ctx.characters().get(0).name());
assertEquals("Rôdeur du Nord, héritier d'Isildur.", ctx.characters().get(0).snippet());
assertEquals("Legolas", ctx.characters().get(1).name());
assertEquals("", ctx.characters().get(1).snippet());
// PNJ triés par order croissant : Elara (1) avant Borin (2)
assertEquals(2, ctx.npcs().size());
assertEquals("Dame Elara", ctx.npcs().get(0).name());
assertEquals("", ctx.npcs().get(0).snippet());
assertEquals("Borin le forgeron", ctx.npcs().get(1).name());
assertEquals("Nain barbu au regard perçant, ancien clan Feuillefer.",
ctx.npcs().get(1).snippet());
}
@Test
void testBuild_TruncatesLongSnippet() {
// Snippet > 160 chars : doit être tronqué à 159 + "…"
String longLine = "x".repeat(200);
Npc longNpc = Npc.builder().id("n-1").campaignId("camp-1").order(1)
.name("Verbeux").markdownContent(longLine).build();
when(campaignRepository.findById("camp-1")).thenReturn(Optional.of(campaign));
when(arcRepository.findByCampaignId("camp-1")).thenReturn(List.of());
when(npcRepository.findByCampaignId("camp-1")).thenReturn(List.of(longNpc));
CampaignStructuralContext ctx = builder.build("camp-1");
String snippet = ctx.npcs().get(0).snippet();
assertEquals(160, snippet.length());
assertTrue(snippet.endsWith("…"));
}
@Test
void testBuild_CountsIllustrationsNullSafe() {
Arc arc = Arc.builder().id("arc-1").name("Arc").description("").order(1)

58
core/src/test/java/com/loremind/application/generationcontext/NarrativeEntityContextBuilderTest.java
View File

@@ -2,9 +2,13 @@ package com.loremind.application.generationcontext;
import com.loremind.domain.campaigncontext.Arc;
import com.loremind.domain.campaigncontext.Chapter;
import com.loremind.domain.campaigncontext.Character;
import com.loremind.domain.campaigncontext.Npc;
import com.loremind.domain.campaigncontext.Scene;
import com.loremind.domain.campaigncontext.ports.ArcRepository;
import com.loremind.domain.campaigncontext.ports.ChapterRepository;
import com.loremind.domain.campaigncontext.ports.CharacterRepository;
import com.loremind.domain.campaigncontext.ports.NpcRepository;
import com.loremind.domain.campaigncontext.ports.SceneRepository;
import com.loremind.domain.generationcontext.NarrativeEntityContext;
import org.junit.jupiter.api.Test;
@@ -30,6 +34,8 @@ public class NarrativeEntityContextBuilderTest {
@Mock private ArcRepository arcRepository;
@Mock private ChapterRepository chapterRepository;
@Mock private SceneRepository sceneRepository;
@Mock private CharacterRepository characterRepository;
@Mock private NpcRepository npcRepository;
@InjectMocks private NarrativeEntityContextBuilder builder;
@@ -107,11 +113,59 @@ public class NarrativeEntityContextBuilderTest {
assertEquals("arc", ctx.entityType());
}
@Test
void testBuild_Character_MarkdownProjected() {
Character c = Character.builder()
.id("c-1").name("Aragorn").markdownContent("# Aragorn\nRôdeur")
.build();
when(characterRepository.findById("c-1")).thenReturn(Optional.of(c));
NarrativeEntityContext ctx = builder.build("character", "c-1");
assertEquals("character", ctx.entityType());
assertEquals("Aragorn", ctx.title());
assertEquals("# Aragorn\nRôdeur", ctx.fields().get("fiche complète (markdown)"));
}
@Test
void testBuild_Npc_MarkdownProjected() {
Npc n = Npc.builder()
.id("n-1").name("Borin le forgeron")
.markdownContent("# Borin\n**Faction :** Clan Feuillefer")
.build();
when(npcRepository.findById("n-1")).thenReturn(Optional.of(n));
NarrativeEntityContext ctx = builder.build("npc", "n-1");
assertEquals("npc", ctx.entityType());
assertEquals("Borin le forgeron", ctx.title());
assertEquals("# Borin\n**Faction :** Clan Feuillefer",
ctx.fields().get("fiche complète (markdown)"));
}
@Test
void testBuild_Npc_NormalizesCase() {
Npc n = Npc.builder().id("n-1").name("Elara").markdownContent("desc").build();
when(npcRepository.findById("n-1")).thenReturn(Optional.of(n));
NarrativeEntityContext ctx = builder.build(" NPC ", "n-1");
assertEquals("npc", ctx.entityType());
}
@Test
void testBuild_NpcNotFoundThrows() {
when(npcRepository.findById("missing")).thenReturn(Optional.empty());
IllegalArgumentException ex = assertThrows(IllegalArgumentException.class,
() -> builder.build("npc", "missing"));
assertTrue(ex.getMessage().contains("missing"));
}
@Test
void testBuild_UnknownTypeThrows() {
IllegalArgumentException ex = assertThrows(IllegalArgumentException.class,
() -> builder.build("npc", "id"));
assertTrue(ex.getMessage().contains("npc"));
() -> builder.build("alien", "id"));
assertTrue(ex.getMessage().contains("alien"));
}
@Test

2
core/src/test/java/com/loremind/application/generationcontext/StreamChatForCampaignUseCaseTest.java
View File

@@ -55,7 +55,7 @@ public class StreamChatForCampaignUseCaseTest {
@SuppressWarnings("unchecked")
@BeforeEach
void setUp() {
campaignCtx = new CampaignStructuralContext("X", "d", List.of(), List.of());
campaignCtx = new CampaignStructuralContext("X", "d", List.of(), List.of(), List.of());
messages = List.of();
onUsage = mock(Consumer.class);
onToken = mock(Consumer.class);

1
core/src/test/java/com/loremind/domain/generationcontext/CampaignStructuralContextTest.java
View File

@@ -43,6 +43,7 @@ class CampaignStructuralContextTest {
"Les Ombres",
"Une campagne dark fantasy",
List.of(arc),
List.of(),
List.of());
assertEquals("Les Ombres", ctx.campaignName());

2
core/src/test/java/com/loremind/domain/generationcontext/ChatRequestTest.java
View File

@@ -56,7 +56,7 @@ class ChatRequestTest {
ChatRequest request = ChatRequest.builder()
.messages(sampleMessages)
.campaignContext(new CampaignStructuralContext(
"Les Ombres", "...", List.of(), List.of()))
"Les Ombres", "...", List.of(), List.of(), List.of()))
.narrativeEntity(new NarrativeEntityContext(
"scene", "L'auberge", Map.of("location", "Taverne")))
.build();

10
core/src/test/java/com/loremind/infrastructure/ai/BrainChatPayloadBuilderTest.java
View File

@@ -167,7 +167,7 @@ class BrainChatPayloadBuilderTest {
ChapterSummary chapter = new ChapterSummary("L'arrivee", "...", 0, List.of(scene));
ArcSummary arc = new ArcSummary("Acte I", "Mise en place", 1, List.of(chapter));
CampaignStructuralContext camp = new CampaignStructuralContext(
"Les Ombres", "dark fantasy", List.of(arc), List.of());
"Les Ombres", "dark fantasy", List.of(arc), List.of(), List.of());
ChatRequest req = ChatRequest.builder().messages(sampleMessages).campaignContext(camp).build();
Map<String, Object> payload = builder.build(req);
@@ -200,7 +200,7 @@ class BrainChatPayloadBuilderTest {
void build_arcSummary_omitsIllustrationCount_whenZero() {
ArcSummary arc = new ArcSummary("A", "", 0, List.of());
CampaignStructuralContext camp = new CampaignStructuralContext(
"X", "", List.of(arc), List.of());
"X", "", List.of(arc), List.of(), List.of());
ChatRequest req = ChatRequest.builder().messages(sampleMessages).campaignContext(camp).build();
Map<String, Object> payload = builder.build(req);
@@ -217,7 +217,7 @@ class BrainChatPayloadBuilderTest {
ChapterSummary chapter = new ChapterSummary("Ch", "", 0, List.of(scene));
ArcSummary arc = new ArcSummary("A", "", 0, List.of(chapter));
CampaignStructuralContext camp = new CampaignStructuralContext(
"X", "", List.of(arc), List.of());
"X", "", List.of(arc), List.of(), List.of());
ChatRequest req = ChatRequest.builder().messages(sampleMessages).campaignContext(camp).build();
Map<String, Object> payload = builder.build(req);
@@ -236,7 +236,7 @@ class BrainChatPayloadBuilderTest {
ChapterSummary chapter = new ChapterSummary("Ch", "", 0, List.of(scene));
ArcSummary arc = new ArcSummary("A", "", 0, List.of(chapter));
CampaignStructuralContext camp = new CampaignStructuralContext(
"X", "", List.of(arc), List.of());
"X", "", List.of(arc), List.of(), List.of());
ChatRequest req = ChatRequest.builder().messages(sampleMessages).campaignContext(camp).build();
Map<String, Object> payload = builder.build(req);
@@ -269,7 +269,7 @@ class BrainChatPayloadBuilderTest {
@Test
void build_campaignScenario_includesBothContextsAndEntity() {
CampaignStructuralContext camp = new CampaignStructuralContext(
"X", "", List.of(), List.of());
"X", "", List.of(), List.of(), List.of());
NarrativeEntityContext entity = new NarrativeEntityContext("arc", "T", Map.of());
ChatRequest req = ChatRequest.builder()
.messages(sampleMessages)